Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Jul 26, 2023

In JMH Core benchmarks, we would like to make sure that every core on the machine is symmetric. This is important for single-threaded benchmarks to make sense.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/117/head:pull/117
$ git checkout pull/117

Update a local copy of the PR:
$ git checkout pull/117
$ git pull https://git.openjdk.org/jmh.git pull/117/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 117

View PR using the GUI difftool:
$ git pr show -t 117

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/117.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 26, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 26, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 26, 2023

Webrevs

@shipilev shipilev merged commit 843f641 into openjdk:master Jul 27, 2023
@shipilev shipilev deleted the CODETOOLS-7903510-corebench-coretests branch July 27, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant