7903898: JMH: Unsafe deprecation warnings are printed in JDK 24 #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is printed for every benchmark running with JDK 24 now:
These have not failed for a long time, so we can just trust the padding works. This will also avoid running some of this checking code during benchmark execution, adding to benchmark accuracy.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/140/head:pull/140$ git checkout pull/140Update a local copy of the PR:
$ git checkout pull/140$ git pull https://git.openjdk.org/jmh.git pull/140/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 140View PR using the GUI difftool:
$ git pr show -t 140Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/140.diff
Using Webrev
Link to Webrev Comment