Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Dec 5, 2024

This is printed for every benchmark running with JDK 24 now:

WARNING: A terminally deprecated method in sun.misc.Unsafe has been called
WARNING: sun.misc.Unsafe::objectFieldOffset has been called by org.openjdk.jmh.util.Utils (file:/Users/shipilev/Work/shipilev-jmh/jmh-samples/target/benchmarks.jar)
WARNING: Please consider reporting this to the maintainers of class org.openjdk.jmh.util.Utils
WARNING: sun.misc.Unsafe::objectFieldOffset will be removed in a future release

These have not failed for a long time, so we can just trust the padding works. This will also avoid running some of this checking code during benchmark execution, adding to benchmark accuracy.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • CODETOOLS-7903898: JMH: Unsafe deprecation warnings are printed in JDK 24 (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/140/head:pull/140
$ git checkout pull/140

Update a local copy of the PR:
$ git checkout pull/140
$ git pull https://git.openjdk.org/jmh.git pull/140/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 140

View PR using the GUI difftool:
$ git pr show -t 140

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/140.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 5, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title CODETOOLS-7903898: JMH: Unsafe deprecation warnings are printed in JDK 24 7903898: JMH: Unsafe deprecation warnings are printed in JDK 24 Dec 5, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 5, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2024

Webrevs

@shipilev shipilev merged commit 7abb6ba into openjdk:master Dec 6, 2024
13 checks passed
@shipilev shipilev deleted the CODETOOLS-7903898-unsafe-deprecation-warnings branch January 8, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant