Skip to content

Conversation

@galderz
Copy link
Contributor

@galderz galderz commented May 9, 2025

Fixes https://bugs.openjdk.org/browse/CODETOOLS-7903998


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • CODETOOLS-7903998: Move checkstyle/findbugs xml to under src/test/resources (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/157/head:pull/157
$ git checkout pull/157

Update a local copy of the PR:
$ git checkout pull/157
$ git pull https://git.openjdk.org/jmh.git pull/157/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 157

View PR using the GUI difftool:
$ git pr show -t 157

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/157.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2025

👋 Welcome back galder! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 9, 2025

@galderz This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7903998: Move checkstyle/findbugs xml to under src/test/resources

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label May 9, 2025
@mlbridge
Copy link

mlbridge bot commented May 9, 2025

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK! Thanks for handling this one.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 9, 2025
@galderz
Copy link
Contributor Author

galderz commented May 14, 2025

You're welcome @shipilev :)

@shipilev
Copy link
Member

If you want to integrate, you have to instruct bots to do so.

@galderz
Copy link
Contributor Author

galderz commented May 14, 2025

Ah yes keep forgetting to do that 😅

@galderz
Copy link
Contributor Author

galderz commented May 14, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 14, 2025
@openjdk
Copy link

openjdk bot commented May 14, 2025

@galderz
Your change (at version bbf5b31) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 14, 2025

Going to push as commit 872b720.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 14, 2025
@openjdk openjdk bot closed this May 14, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 14, 2025
@openjdk
Copy link

openjdk bot commented May 14, 2025

@shipilev @galderz Pushed as commit 872b720.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants