CODETOOLS-7902813: Amend experimental compiler-assisted blackhole support #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
shipilev
force-pushed
the
CODETOOLS-7902813-blackhole-static
branch
from
e45b940
to
d46c680
Compare
shipilev
force-pushed
the
CODETOOLS-7902813-blackhole-static
branch
2 times, most recently
from
ce29ce9
to
93cfa23
Compare
shipilev
force-pushed
the
CODETOOLS-7902813-blackhole-static
branch
from
93cfa23
to
bfb0286
Compare
shipilev
changed the title
Webrevs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDK-8258619 changes the requirements for compiler-assisted blackholes to be empty static methods. This requires adjustments to JMH Blackhole itself.
Progress
Issue
Download
$ git fetch https://git.openjdk.java.net/jmh pull/16/head:pull/16$ git checkout pull/16