Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODETOOLS-7902929: JMH generators fail for benchmark in unnamed package #39

Closed
wants to merge 1 commit into from

Conversation

retronym
Copy link
Contributor

@retronym retronym commented May 10, 2021


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmh pull/39/head:pull/39
$ git checkout pull/39

Update a local copy of the PR:
$ git checkout pull/39
$ git pull https://git.openjdk.java.net/jmh pull/39/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 39

View PR using the GUI difftool:
$ git pr show -t 39

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmh/pull/39.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2021

👋 Welcome back jzaugg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 10, 2021
@mlbridge
Copy link

mlbridge bot commented May 10, 2021

Webrevs

@shipilev shipilev changed the title CODETOOLS-7902929 NPE in reflection/asm generator + unnamed package CODETOOLS-7902929: JMH generators fail for benchmark in unnamed package May 11, 2021
@openjdk
Copy link

openjdk bot commented May 11, 2021

@retronym This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7902929: JMH generators fail for benchmark in unnamed package

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 0aeda8d: CODETOOLS-7902933: JMH: Update test JDK lists for GHA

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 11, 2021
@shipilev
Copy link
Member

@retronym, say /integrate?

@retronym
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 12, 2021
@openjdk
Copy link

openjdk bot commented May 12, 2021

@retronym
Your change (at version a9c0535) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk openjdk bot closed this May 12, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 12, 2021
@openjdk
Copy link

openjdk bot commented May 12, 2021

@shipilev @retronym Since your change was applied there has been 1 commit pushed to the master branch:

  • 0aeda8d: CODETOOLS-7902933: JMH: Update test JDK lists for GHA

Your commit was automatically rebased without conflicts.

Pushed as commit 768f38e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants