Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODETOOLS-7903110: JMH: perfasm support for configurable event count normalization #63

merged 6 commits into from Feb 23, 2022


Copy link

@shipilev shipilev commented Feb 22, 2022

When comparing perfasm outputs from bechmarks that run at different speeds, it is hard to disambiguate how the profile changes. Since in both "slower" and "faster" cases the counts add up to 100%, a distributed hotspot can show up at the same percentage level.

Additionally, it is sometimes useful to see the raw counters, to ballpark how accurate the percents are.


  • Change must not contain extraneous whitespace
  • Change must be properly reviewed



Using git

Checkout this PR locally:
$ git fetch pull/63/head:pull/63
$ git checkout pull/63

Update a local copy of the PR:
$ git checkout pull/63
$ git pull pull/63/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 63

View PR using the GUI difftool:
$ git pr show -t 63

Using diff file

Download this PR as a diff file:

Copy link

bridgekeeper bot commented Feb 22, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 22, 2022
Copy link

mlbridge bot commented Feb 22, 2022


@shipilev shipilev merged commit 35ecd9f into openjdk:master Feb 23, 2022
@shipilev shipilev deleted the 7903110-perfasm-count-normalization branch April 14, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
rfr Pull request is ready for review
1 participant