Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903161: JMH: Remove perfasm "printCompilationInfo" option #70



Copy link

@shipilev shipilev commented Apr 14, 2022

This option was added in early days of perfasm, but now it is both bitrotten (TraceClassLoading flag got deprecated), it serves little purpose given how perfasm is now tracking the compilation versions for every method, and the output would be hard to correlate with perfasm anyway.

We should just remove this option to avoid confusion.


  • Change must not contain extraneous whitespace
  • Change must be properly reviewed



Using git

Checkout this PR locally:
$ git fetch pull/70/head:pull/70
$ git checkout pull/70

Update a local copy of the PR:
$ git checkout pull/70
$ git pull pull/70/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 70

View PR using the GUI difftool:
$ git pr show -t 70

Using diff file

Download this PR as a diff file:

Copy link

bridgekeeper bot commented Apr 14, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 14, 2022
Copy link

mlbridge bot commented Apr 14, 2022


@shipilev shipilev merged commit 05045a9 into openjdk:master Apr 28, 2022
@shipilev shipilev deleted the 7903161-perfasm-remove-printcompilationinfo branch June 24, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
rfr Pull request is ready for review
1 participant