7903319: The methods 'getAllMethods' and 'getMethods' in class 'BenchmarkGeneratorUtils' have the same feature

[lgxbslgx]

Hi all,

Currently, the methods getAllMethods and getMethods in class 'BenchmarkGeneratorUtils' have the same feature. This patch removes getMethods and keeps getAllMethods because getAllMethods is consistent with getAllFields.

Thanks for taking the time to review.

Best Regards,
-- Guoxiong

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• CODETOOLS-7903319: The methods 'getAllMethods' and 'getMethods' in class 'BenchmarkGeneratorUtils' have the same feature

Reviewers

• Aleksey Shipilev (@shipilev - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh pull/78/head:pull/78
$ git checkout pull/78

Update a local copy of the PR:
$ git checkout pull/78
$ git pull https://git.openjdk.org/jmh pull/78/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 78

View PR using the GUI difftool:
$ git pr show -t 78

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/78.diff

[bridgekeeper]

👋 Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (541c5838)

[shipilev]

Looks fine, thanks!

[openjdk]

@lgxbslgx This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7903319: The methods 'getAllMethods' and 'getMethods' in class 'BenchmarkGeneratorUtils' have the same feature

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[lgxbslgx]

@shipilev Thanks for the review. Could I get your help to sponsor this patch?

[lgxbslgx]

/integrate

[openjdk]

@lgxbslgx
Your change (at version 541c583) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 8c7fedc.

[openjdk]

@shipilev @lgxbslgx Pushed as commit 8c7fedc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.