7903440: JMH: Add automatic module names

[hendrikebbers]

maven-jar-plugin is used to add "Automatic-Module-Name" to MANIFEST.MF at buildtime. This is the minimum that is needed if you want to use the lib on the module path in a project.

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• CODETOOLS-7903440: JMH: Add automatic module names (Enhancement - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/90/head:pull/90
$ git checkout pull/90

Update a local copy of the PR:
$ git checkout pull/90
$ git pull https://git.openjdk.org/jmh.git pull/90/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 90

View PR using the GUI difftool:
$ git pr show -t 90

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/90.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @hendrikebbers, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user hendrikebbers" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[hendrikebbers]

/signed

[bridgekeeper]

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[hendrikebbers]

@shipilev would this change be ok for you?
I will double check the state of the OCA - did this years ago ;)

[mlbridge]

Webrevs

• 01: Full - Incremental (2dfe381c)
• 00: Full (8a3ee240)

[hendrikebbers]

@shipilev ping :)

[shipilev]

Please go to https://github.com/hendrikebbers/jmh/actions -- and enable the testing workflows there? You would probably want to merge from the current master to get all the fixes in.

[shipilev]

I am actually on the fence with this change. Module names are the part of external API, so picking the correct name is important, as it is supposed to remain stable. This is probably okay for JMH, as we seldom change the API to begin with.

I assume you wanted to capture the package names as module names? If so, why org.openjdk.jmh.core then? There is no package name like that. Can it be org.openjdk.jmh, or does it introduce split packages problem downstream?

[hendrikebbers]

@shipilev totally fine with the name change. Will do it and ping you once all checks are green

[hendrikebbers]

@shipilev updated

[hendrikebbers]

@shipilev ping :)

[hendrikebbers]

@shipilev ping :)

[hendrikebbers]

Hi @shipilev can you tell me if there is a problem with the PR. Totally fine to change it and continue to work own it bit I would really like to get module names added to JMH ;)

[shipilev]

Hi @shipilev can you tell me if there is a problem with the PR. Totally fine to change it and continue to work own it bit I would really like to get module names added to JMH ;)

Apologies, I keep getting distracted.

Part of me do not want to commit to a particular API, even for modules. But I guess it does no harm, and we can plausibly change the automatic module names later if found current ones unfortunate. Even though it would be the API-breaking change.

[openjdk]

@hendrikebbers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7903440: JMH: Add automatic module names

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• 362d657: Continue in 1.38-SNAPSHOT
• 2effa2c: JMH v1.37.
• 09c78d5: 7903508: JMH: Remove the Unicode dot prefix from secondary results
• 843f641: 7903510: JMH: Add core performance checking tests
• 8bc325b: 7903511: JMH: Add score stability performance tests
• 6b09724: 7903450: JMH: Improve -prof perfnorm accuracy with robust estimations
• d88f901: 7903504: JMH: Fix new Sonar warnings
• 47f651b: 7903498: JMH: Reset worker interrupt status after iteration
• 482561a: 7903492: JMH: Infrastructure code should yield occasionally for virtual executor to make progress
• 9a97557: 7903490: JMH: The interrupt to time-outing benchmark can be delivered to worker data barrier
• ... and 16 more: https://git.openjdk.org/jmh/compare/115862608176fe2dbfd1151eb820d210fa0aa47f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).