7903440: JMH: Add automatic module names #90
Hi @hendrikebbers, welcome to this OpenJDK project and thanks for contributing!
We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing
If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user hendrikebbers" as summary for the issue.
If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing
I am actually on the fence with this change. Module names are the part of external API, so picking the correct name is important, as it is supposed to remain stable. This is probably okay for JMH, as we seldom change the API to begin with.
I assume you wanted to capture the package names as module names? If so, why
Apologies, I keep getting distracted.
Part of me do not want to commit to a particular API, even for modules. But I guess it does no harm, and we can plausibly change the automatic module names later if found current ones unfortunate. Even though it would be the API-breaking change.
@hendrikebbers This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been 26 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type