Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903409: JMH: Add JMH Visualizer as a community project #91

Closed
wants to merge 3 commits into from

Conversation

lenguyenthanh
Copy link
Contributor

@lenguyenthanh lenguyenthanh commented Dec 26, 2022


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh pull/91/head:pull/91
$ git checkout pull/91

Update a local copy of the PR:
$ git checkout pull/91
$ git pull https://git.openjdk.org/jmh pull/91/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 91

View PR using the GUI difftool:
$ git pr show -t 91

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/91.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 26, 2022

Hi @lenguyenthanh, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user lenguyenthanh" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Dec 26, 2022
@lenguyenthanh
Copy link
Contributor Author

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Dec 26, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 26, 2022

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@plokhotnyuk
Copy link

@lenguyenthanh Please, add JMH Visualizer too.

@lenguyenthanh lenguyenthanh changed the title Add sbt plugin as a related project Add some more community projects Dec 27, 2022
@lenguyenthanh lenguyenthanh changed the title Add some more community projects Add JMH Visualizer as a community project Dec 29, 2022
@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Jan 9, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 9, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2023

Webrevs

@shipilev shipilev changed the title Add JMH Visualizer as a community project 7903409: JMH: Add JMH Visualizer as a community project Jan 12, 2023
Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks.

@openjdk
Copy link

openjdk bot commented Jan 12, 2023

@lenguyenthanh This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7903409: JMH: Add JMH Visualizer as a community project

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 12, 2023
@lenguyenthanh
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 12, 2023
@openjdk
Copy link

openjdk bot commented Jan 12, 2023

@lenguyenthanh
Your change (at version 6a3ded2) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 12, 2023

Going to push as commit 0248217.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 12, 2023
@openjdk openjdk bot closed this Jan 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 12, 2023
@openjdk
Copy link

openjdk bot commented Jan 12, 2023

@shipilev @lenguyenthanh Pushed as commit 0248217.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lenguyenthanh lenguyenthanh deleted the patch-1 branch January 12, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants