Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODETOOLS-7902835: JOL: ObjectShapes.processJAR should close resources properly #9

Merged
merged 2 commits into from
Mar 8, 2021

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Mar 8, 2021

SonarCloud instance reports a few easy-to-fix issues in this method.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

Download

$ git fetch https://git.openjdk.java.net/jol pull/9/head:pull/9
$ git checkout pull/9

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 8, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 8, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 8, 2021

Webrevs

@shipilev shipilev merged commit 1f34d1b into openjdk:master Mar 8, 2021
@shipilev shipilev deleted the CODETOOLS-7902835-objectshapes branch March 25, 2021 15:12
inponomarev pushed a commit to atp-mipt/jol that referenced this pull request Feb 14, 2022
Bumps maven-gpg-plugin from 1.5 to 1.6.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
VityaP added a commit to atp-mipt/jol that referenced this pull request Mar 22, 2022
VityaP added a commit to atp-mipt/jol that referenced this pull request Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
1 participant