Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7902638: TestResult may count lines incorrectly #1

Merged
merged 1 commit into from Apr 24, 2020
Merged

Conversation

@dbessono
Copy link
Collaborator

@dbessono dbessono commented Apr 7, 2020

This is the fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902638
Changed behavior to handle not only "\n" as line ending but "\r" and "\r\n" as well.
Updated regression tests that were matching the current behavior and so started to fail.


Progress

  • Change must not contain extraneous whitespace

Issue

Reviewers

  • Jonathan Gibbons (jjg - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jtharness pull/1/head:pull/1
$ git checkout pull/1

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 7, 2020

👋 Welcome back dbessono! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 21, 2020

@dbessono This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

7902638: TestResult may count lines incorrectly

Reviewed-by: jjg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate e583a71778890ff5e71040b4d03a92fd53469f93.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 21, 2020

Webrevs

Copy link
Collaborator

@jonathan-gibbons jonathan-gibbons left a comment

Looks good to me.

@dbessono dbessono merged commit 35de137 into master Apr 24, 2020
1 check passed
1 check passed
@openjdk
jcheck
Details
@dbessono dbessono requested a review from jonathan-gibbons Apr 24, 2020
@jonathan-gibbons
Copy link
Collaborator

@jonathan-gibbons jonathan-gibbons commented Apr 24, 2020

Still looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants