-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7903563: Feature Tests - Adding five JavaTest GUI legacy automated test scripts #52
Conversation
👋 Welcome back gollayadav! A progress list of the required criteria for merging this PR into |
@gollayadav This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dbessono) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here are significant and more than just adding 5 tests. For example the changes to gui-tests/src/gui/src/jthtest/Tools.java are huge. Would appreciate to have them explained and ideally split into different a PR to make sure that no impact or regression on the existing tests is introduced.
Reverting "Tools.java" file and creating a separate PR for this to avoid any confusions.
I will close this PR and create an separate PR for ReportCreate.java and Tools.java files to avoid any regression issues. |
Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.
1.ReportCreate14.java
2.ReportCreate15.java
3.ReportCreate16.java
4.ReportCreate17.java
5.ReportCreate18.java
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtharness.git pull/52/head:pull/52
$ git checkout pull/52
Update a local copy of the PR:
$ git checkout pull/52
$ git pull https://git.openjdk.org/jtharness.git pull/52/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 52
View PR using the GUI difftool:
$ git pr show -t 52
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jtharness/pull/52.diff
Webrev
Link to Webrev Comment