Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903563: Feature Tests - Adding five JavaTest GUI legacy automated test scripts #52

Closed
wants to merge 6 commits into from

Conversation

gollayadav
Copy link
Contributor

@gollayadav gollayadav commented Sep 28, 2023

Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.

1.ReportCreate14.java
2.ReportCreate15.java
3.ReportCreate16.java
4.ReportCreate17.java
5.ReportCreate18.java


Progress

  • Change must not contain extraneous whitespace

Issue

  • CODETOOLS-7903563: Feature Tests - Adding five JavaTest GUI legacy automated test scripts (Sub-task - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtharness.git pull/52/head:pull/52
$ git checkout pull/52

Update a local copy of the PR:
$ git checkout pull/52
$ git pull https://git.openjdk.org/jtharness.git pull/52/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 52

View PR using the GUI difftool:
$ git pr show -t 52

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtharness/pull/52.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 28, 2023

👋 Welcome back gollayadav! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@gollayadav This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7903563: Feature Tests - Adding five JavaTest GUI legacy automated test scripts

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • ff2d564: 7903466: Feature Tests - Adding five JavaTest GUI legacy automated test scripts

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dbessono) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 28, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 28, 2023

Webrevs

Copy link
Collaborator

@dbessono dbessono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here are significant and more than just adding 5 tests. For example the changes to gui-tests/src/gui/src/jthtest/Tools.java are huge. Would appreciate to have them explained and ideally split into different a PR to make sure that no impact or regression on the existing tests is introduced.

Reverting "Tools.java" file and creating a separate PR for this to avoid any confusions.
@gollayadav
Copy link
Contributor Author

I will close this PR and create an separate PR for ReportCreate.java and Tools.java files to avoid any regression issues.

@gollayadav gollayadav closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants