Skip to content
This repository has been archived by the owner. It is now read-only.
Permalink
Browse files
8240915: Shenandoah: Remove unused fields in init mark tasks
Reviewed-by: rkennke
  • Loading branch information
zhengyu123 committed Mar 12, 2020
1 parent 21d3eaf commit 1f189228b63a8dfcb69f331e5039f1c29fbbe851
Showing with 4 additions and 8 deletions.
  1. +4 −6 src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp
  2. +0 −2 src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp
@@ -84,12 +84,10 @@ template<UpdateRefsMode UPDATE_REFS>
class ShenandoahInitMarkRootsTask : public AbstractGangTask {
private:
ShenandoahAllRootScanner* _rp;
bool _process_refs;
public:
ShenandoahInitMarkRootsTask(ShenandoahAllRootScanner* rp, bool process_refs) :
ShenandoahInitMarkRootsTask(ShenandoahAllRootScanner* rp) :
AbstractGangTask("Shenandoah init mark roots task"),
_rp(rp),
_process_refs(process_refs) {
_rp(rp) {
}

void work(uint worker_id) {
@@ -268,12 +266,12 @@ void ShenandoahConcurrentMark::mark_roots(ShenandoahPhaseTimings::Phase root_pha
task_queues()->reserve(nworkers);

if (heap->has_forwarded_objects()) {
ShenandoahInitMarkRootsTask<RESOLVE> mark_roots(&root_proc, _heap->process_references());
ShenandoahInitMarkRootsTask<RESOLVE> mark_roots(&root_proc);
workers->run_task(&mark_roots);
} else {
// No need to update references, which means the heap is stable.
// Can save time not walking through forwarding pointers.
ShenandoahInitMarkRootsTask<NONE> mark_roots(&root_proc, _heap->process_references());
ShenandoahInitMarkRootsTask<NONE> mark_roots(&root_proc);
workers->run_task(&mark_roots);
}

@@ -162,8 +162,6 @@ class ShenandoahInitTraversalCollectionTask : public AbstractGangTask {
private:
ShenandoahCSetRootScanner* _rp;
ShenandoahHeap* _heap;
ShenandoahCsetCodeRootsIterator* _cset_coderoots;
ShenandoahStringDedupRoots _dedup_roots;

public:
ShenandoahInitTraversalCollectionTask(ShenandoahCSetRootScanner* rp) :

0 comments on commit 1f18922

Please sign in to comment.