8262313: Override stencilAttachmentPixelFormat to maintain appropriate state

jayathirthrao · jayathirthrao · commit 223e3cba58f0 · 2021-02-24T16:42:42.000Z
diff --git a/src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPipelineStatesStorage.m b/src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPipelineStatesStorage.m
@@ -196,6 +196,11 @@ - (NSPointerArray * ) getSubStates:(NSString *)vertexShaderId fragmentShader:(NS
             }
             if (stencilNeeded) {
                 pipelineDesc.stencilAttachmentPixelFormat = MTLPixelFormatStencil8;
+            } else {
+                // We continue to use same encoder when we move from shape clip
+                // to other opcodes. So we need to maintain apprppriate state
+                // for stencilAttachmentPixelFormat until we end the encoder
+                pipelineDesc.stencilAttachmentPixelFormat = MTLPixelFormatInvalid;
             }
 
             if (renderOptions->isAA) {

Original file line number	Diff line number	Diff line change
`@@ -196,6 +196,11 @@ - (NSPointerArray * ) getSubStates:(NSString *)vertexShaderId fragmentShader:(NS`
`196`	`196`	`}`
`197`	`197`	`if (stencilNeeded) {`
`198`	`198`	`pipelineDesc.stencilAttachmentPixelFormat = MTLPixelFormatStencil8;`
	`199`	`+ } else {`
	`200`	`+ // We continue to use same encoder when we move from shape clip`
	`201`	`+ // to other opcodes. So we need to maintain apprppriate state`
	`202`	`+ // for stencilAttachmentPixelFormat until we end the encoder`
	`203`	`+ pipelineDesc.stencilAttachmentPixelFormat = MTLPixelFormatInvalid;`
`199`	`204`	`}`
`200`	`205`
`201`	`206`	`if (renderOptions->isAA) {`