Skip to content
This repository has been archived by the owner. It is now read-only.
Permalink
Browse files
8253433: Remove -XX:+Debugging product option
Reviewed-by: kbarrett, stuefe, dholmes
  • Loading branch information
coleenp committed Oct 5, 2020
1 parent 81dae70 commit 4d29116d6d5f902098bd394e3f78e9cc6852113a
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 7 deletions.
@@ -553,6 +553,7 @@ static SpecialFlag const special_jvm_flags[] = {
{ "UseSemaphoreGCThreadsSynchronization", JDK_Version::undefined(), JDK_Version::jdk(16), JDK_Version::jdk(17) },
{ "ForceNUMA", JDK_Version::jdk(15), JDK_Version::jdk(16), JDK_Version::jdk(17) },
{ "InsertMemBarAfterArraycopy", JDK_Version::undefined(), JDK_Version::jdk(16), JDK_Version::jdk(17) },
{ "Debugging", JDK_Version::undefined(), JDK_Version::jdk(16), JDK_Version::jdk(17) },

#ifdef TEST_VERIFY_SPECIAL_JVM_FLAGS
// These entries will generate build errors. Their purpose is to test the macros.
@@ -395,10 +395,6 @@ const intx ObjectAlignmentInBytes = 8;
notproduct(bool, WalkStackALot, false, \
"Trace stack (no print) at every exit from the runtime system") \
\
product(bool, Debugging, false, \
"Set when executing debug methods in debug.cpp " \
"(to prevent triggering assertions)") \
\
notproduct(bool, VerifyLastFrame, false, \
"Verify oops on last frame on entry to VM") \
\
@@ -71,6 +71,9 @@ static intx g_asserting_thread = 0;
static void* g_assertion_context = NULL;
#endif // CAN_SHOW_REGISTERS_ON_ASSERT

// Set to suppress secondary error reporting.
bool Debugging = false;

#ifndef ASSERT
# ifdef _DEBUG
// NOTE: don't turn the lines below into a comment -- if you're getting
@@ -367,9 +370,9 @@ class Command : public StackObj {
}

~Command() {
tty->flush();
Debugging = debug_save;
level--;
tty->flush();
Debugging = debug_save;
level--;
}
};

@@ -152,6 +152,10 @@ enum VMErrorType {
OOM_MMAP_ERROR = 0xe0000002
};

// Set to suppress secondary error reporting.
// Really should have a qualified name or something.
extern bool Debugging;

// error reporting helper functions
void report_vm_error(const char* file, int line, const char* error_msg);
void report_vm_error(const char* file, int line, const char* error_msg,

0 comments on commit 4d29116

Please sign in to comment.