Skip to content
Permalink
Browse files

8241960: The SHA3 message digests impl of SUN provider are not thread…

… safe after cloned

Fix sun.security.provider.SHA3 class to correctly clone its lanes field

Reviewed-by: valeriep
  • Loading branch information
Alexey Bakhtin committed Apr 3, 2020
1 parent 512644d commit 76d534986b47a16f4229a6a994223d02687a04f7
@@ -62,7 +62,7 @@
};

private byte[] state = new byte[WIDTH];
private final long[] lanes = new long[DM*DM];
private long[] lanes = new long[DM*DM];

/**
* Creates a new SHA-3 object.
@@ -259,6 +259,7 @@ private void keccak() {
public Object clone() throws CloneNotSupportedException {
SHA3 copy = (SHA3) super.clone();
copy.state = copy.state.clone();
copy.lanes = new long[DM*DM];
return copy;
}

@@ -0,0 +1,162 @@
/*
* Copyright (c) 2020, Azul Systems, Inc. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

/*
* @test
* @bug 8241960
* @summary Confirm that java.security.MessageDigest is thread-safe after clone.
* @run main/othervm ThreadSafetyTest 5 4
*/

import java.security.MessageDigest;
import java.security.NoSuchAlgorithmException;
import java.security.Provider;
import java.security.Security;
import java.util.Arrays;
import java.util.Random;

// Usage: java ThreadSafetyTest [threadsFactor [duration]]
public class ThreadSafetyTest {

static volatile boolean runrun = true;
static volatile boolean error = false;

private static final String[] ALGORITHM_ARRAY = { "MD2", "MD5",
"SHA1", "SHA-224", "SHA-256", "SHA-384",
"SHA-512", "SHA-512/224", "SHA-512/256",
"SHA3-224", "SHA3-256", "SHA3-384", "SHA3-512" };

public static void main(String[] args) throws Exception {
int threadsFactor = 5;
if (args.length > 0) {
threadsFactor = Integer.parseInt(args[0]);
}
int duration = 4;
if (args.length > 1) {
duration = Integer.parseInt(args[1]);
}
int nProcessors = Runtime.getRuntime().availableProcessors();
int nTasks = nProcessors * threadsFactor;

System.out.println("Testing with " + nTasks + " threads on " +
nProcessors + " processors for " + duration +
" seconds.");

// Initialize input data
byte input[] = new byte[1024];
(new Random()).nextBytes(input);

for (Provider p : Security.getProviders()) {
for (String alg : ALGORITHM_ARRAY) {
try {
MessageDigest md = MessageDigest.getInstance(alg, p);
testThreadSafety(md, input, nTasks, duration, false);

if (isClonable(md)) {
md.reset();
testThreadSafety(md, input, nTasks, duration, true);
}
} catch (NoSuchAlgorithmException nae) {
// algorithm not supported, just skip
}
}
}
}

static private void testThreadSafety(final MessageDigest originalMD,
final byte[] input, final int nTasks,
final int duration, final boolean useClone) {
Thread[] tasks = new Thread[nTasks];

byte[] expectedOut = getHash(originalMD, input, useClone);
originalMD.reset();

runrun = true;

for (int i = 0; i < nTasks; i++) {
tasks[i] = new Thread(new Runnable() {
public void run() {
MessageDigest md = getMessageDigest(originalMD, useClone);
while (runrun) {
byte newOut[] = getHash(md, input, useClone);
if (!Arrays.equals(expectedOut, newOut)) {
runrun = false;
error = true;
}
}
}
});
}
for (int i = 0; i < nTasks; i++) {
tasks[i].start();
}

try {
for (int i = 0; runrun && i < duration; i++) {
Thread.sleep(1000); // 1 second
}
runrun = false;
for (int i = 0; i < nTasks; i++) {
tasks[i].join();
}
} catch (InterruptedException e) {
}
if (error) {
throw new RuntimeException("MessageDigest " + originalMD.getAlgorithm() +
" in the provider " + originalMD.getProvider().getName() +
" is not thread-safe" + (useClone?" after clone.":"." ));
}
}

static private byte[] getHash(final MessageDigest messageDigest,
final byte[] input, final boolean useClone) {
for (int i = 0; i < 100; i++)
messageDigest.update(input);
return messageDigest.digest();
}

static private MessageDigest getMessageDigest(final MessageDigest prototype,
final boolean useClone) {
try {
if (useClone) {
return (MessageDigest)prototype.clone();
}
return MessageDigest.getInstance(
prototype.getAlgorithm(), prototype.getProvider());
} catch (final CloneNotSupportedException | NoSuchAlgorithmException e) {
throw new RuntimeException(e);
}
}

// The impls from libucrypto does not support clone but ones
// from libmd do.
static private boolean isClonable(final MessageDigest messageDigest) {
try {
messageDigest.clone();
return true;
} catch (final CloneNotSupportedException e) {
return false;
}
}

}

0 comments on commit 76d5349

Please sign in to comment.