Skip to content
Permalink
Browse files

8241631: PropertyGetterTaglet, PropertySetterTaglet may be removed

Reviewed-by: hannesw
  • Loading branch information
jonathan-gibbons committed Mar 27, 2020
1 parent c17ed6a commit ccc699600f8dc3c4aa105b3dd5b8678f3d9aaeaa
@@ -86,8 +86,6 @@ doclet.not_standard_file_manager = Cannot set taglet path; the file manager is n
doclet.Author=Author:
doclet.DefaultValue=Default value:
doclet.PropertyDescription=Property description:
doclet.PropertyGetter=Gets the value of the property
doclet.PropertySetter=Sets the value of the property
doclet.PropertyGetterWithName=Gets the value of the property {0}.
doclet.PropertySetterWithName=Sets the value of the property {0}.
doclet.Default=Default:

This file was deleted.

This file was deleted.

This file was deleted.

@@ -672,8 +672,6 @@ private void initStandardTaglets() {
* Initialize JavaFX-related tags.
*/
private void initJavaFXTaglets() {
addStandardTaglet(new PropertyGetterTaglet());
addStandardTaglet(new PropertySetterTaglet());
addStandardTaglet(new SimpleTaglet("propertyDescription",
resources.getText("doclet.PropertyDescription"),
EnumSet.of(Location.METHOD, Location.FIELD)));
@@ -78,8 +78,6 @@ public void test1() {
"<dt>Default value:</dt>",
"<dt>Since:</dt>\n"
+ "<dd>JavaFX 8.0</dd>",
"<p>Sets the value of the property <code>Property</code>",
"<p>Gets the value of the property <code>Property</code>",
"<dt>Property description:</dt>",
"<th class=\"col-second\" scope=\"row\"><code><span class=\"member-name-link\">"
+ "<a href=\"#setTestMethodProperty()\">"
@@ -26,13 +26,11 @@
public class C {

/**
* @propertySetter Property
* @propertyDescription PropertyDescription
*/
public void CC() {}

/**
* @propertyGetter Property
*
*/
public void B() {}
@@ -26,13 +26,11 @@
public class C {

/**
* @propertySetter Property
* @propertyDescription PropertyDescription
*/
public void CC() {}

/**
* @propertyGetter Property
*
*/
public void B() {}
@@ -13,8 +13,6 @@
{@literal}: ..... overview module package type constructor method field inline ........
@param: block ........ ...... ....... type constructor method ..... ...... ........
@propertyDescription: block ........ ...... ....... .... ........... method field ...... ........
@propertyGetter: block ........ ...... ....... .... ........... method ..... ...... ........
@propertySetter: block ........ ...... ....... .... ........... method ..... ...... ........
@provides: block ........ module ....... .... ........... ...... ..... ...... ........
@return: block ........ ...... ....... .... ........... method ..... ...... ........
@see: block overview module package type constructor method field ...... ........
@@ -67,8 +67,6 @@ public String toString() {
SERIAL("@serial", ""),
SERIALDATA("@serialData", "The types and order of data could be here."),
SERIALFIELD("@serialField", "\n Serial field in special array"),
FX_PROPSETTER("@propertySetter", "Set the property"),
FX_PROPGETTER("@propertyGetter", "Get the property"),
FX_PROPDESC("@propertyDescription", ""),
FX_DEFVALUE("@defaultValue", ""),
FX_TREATASPRIVATE("@treatAsPrivate", "");
@@ -384,10 +382,7 @@ public String getMethodComment(JCClassDecl baseDecl,

if (isFxStyle) {
// @propertySetter/Getter + Description
if ("void".equals(retType.toString())) {
buildComment += Tag.FX_PROPSETTER + "\n";
} else {
buildComment += Tag.FX_PROPGETTER + "\n";
if (!"void".equals(retType.toString())) {
buildComment += Tag.FX_DEFVALUE.value(defValue(retType.toString()))
+ "\n";
}

0 comments on commit ccc6996

Please sign in to comment.