Skip to content
This repository has been archived by the owner. It is now read-only.
Permalink
Browse files
8251715: Throw UncheckedIOException in place of InternalError when Ht…
…tpClient fails due to unavailability of underlying resources required by SSLContext

This fix updates jdk.internal.net.http.HttpClientImpl to throw an UncheckedIOException instead of InternalError.

Reviewed-by: chegar, dfuchs
  • Loading branch information
rhyadav committed Aug 18, 2020
1 parent ac7f8f8 commit e361a58a5451a4be9cd639337b4eeead4a870fac
Show file tree
Hide file tree
Showing 2 changed files with 64 additions and 1 deletion.
@@ -267,7 +267,7 @@ private HttpClientImpl(HttpClientBuilderImpl builder,
try {
sslContext = SSLContext.getDefault();
} catch (NoSuchAlgorithmException ex) {
throw new InternalError(ex);
throw new UncheckedIOException(new IOException(ex));
}
} else {
sslContext = builder.sslContext;
@@ -0,0 +1,63 @@
/*
* Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

import java.io.UncheckedIOException;
import java.net.http.HttpClient;
import java.security.NoSuchAlgorithmException;
import org.testng.annotations.Test;
import static org.testng.Assert.expectThrows;
import static org.testng.Assert.fail;

/*
* @test
* @bug 8251715
* @summary This test verifies exception when resources for
* SSLcontext used by HttpClient are not available
* @build SSLExceptionTest
* @run testng/othervm -Djdk.tls.client.protocols="InvalidTLSv1.4"
* SSLExceptionTest
*/

public class SSLExceptionTest {

Throwable excp,noSuchAlgo;

static final int ITERATIONS = 10;

@Test
public void testHttpClientsslException() {
for (int i = 0; i < ITERATIONS; i++) {
excp = expectThrows(UncheckedIOException.class, HttpClient.newBuilder()::build);
noSuchAlgo = excp.getCause().getCause();
if ( !(noSuchAlgo instanceof NoSuchAlgorithmException) ) {
fail("Test failed due to wrong exception cause : " + noSuchAlgo);
}
excp = expectThrows(UncheckedIOException.class, HttpClient::newHttpClient);
noSuchAlgo = excp.getCause().getCause();
if ( !(noSuchAlgo instanceof NoSuchAlgorithmException) ) {
fail("Test failed due to wrong exception cause : " + noSuchAlgo);
}
}
}
}

0 comments on commit e361a58

Please sign in to comment.