Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252726: Lanai: IDEA Editor Rendering OGL vs Metal 1:2 #113

Closed
wants to merge 1 commit into from

Conversation

@avu
Copy link
Collaborator

@avu avu commented Oct 9, 2020

Optimized mask cache usage


Progress

  • Change must not contain extraneous whitespace

Testing

Linux x64 Windows x64 macOS x64
Build (3/3 running) (2/2 running) (2/2 running)

Issue

  • JDK-8252726: Lanai: IDEA Editor Rendering OGL vs Metal 1:2

Download

$ git fetch https://git.openjdk.java.net/lanai pull/113/head:pull/113
$ git checkout pull/113

…al 1:2

Optimized mask cache usage
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 9, 2020

👋 Welcome back avu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 9, 2020
@avu
Copy link
Collaborator Author

@avu avu commented Oct 9, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 9, 2020

@avu This PR has not yet been marked as ready for integration.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 9, 2020

Webrevs

@avu
Copy link
Collaborator Author

@avu avu commented Oct 9, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 9, 2020

@avu This PR has not yet been marked as ready for integration.

@avu
Copy link
Collaborator Author

@avu avu commented Oct 9, 2020

/help

@openjdk
Copy link

@openjdk openjdk bot commented Oct 9, 2020

@avu Available commands:

  • cc - add or remove an additional classification label
  • contributor - adds or removes additional contributors for a PR
  • covered - used when employer has signed the OCA
  • csr - require a compatibility and specification request (CSR) for this pull request
  • help - shows this text
  • integrate - performs integration of the changes in the PR
  • issue - edit the list of issues that this PR solves
  • label - add or remove an additional classification label
  • reviewer - manage additional reviewers for a PR
  • reviewers - set the number of additional required reviewers for this PR
  • signed - used after signing the OCA
  • solves - edit the list of issues that this PR solves
  • sponsor - performs integration of a PR that is authored by a non-committer
  • summary - updates the summary in the commit message
  • test - used to run tests
@avu
Copy link
Collaborator Author

@avu avu commented Oct 9, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 9, 2020

@avu This PR has not yet been marked as ready for integration.

@avu
Copy link
Collaborator Author

@avu avu commented Oct 9, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 9, 2020

@avu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252726: Lanai: IDEA Editor Rendering  OGL vs Metal 1:2

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 9, 2020
@avu
Copy link
Collaborator Author

@avu avu commented Oct 9, 2020

/integrate

@openjdk openjdk bot closed this Oct 9, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 9, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 9, 2020

@avu Pushed as commit 6fbe9a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@avu avu deleted the avu:JDK-8252726 branch Dec 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2020

@avu The command integrate can only be used in open pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant