Skip to content
This repository has been archived by the owner. It is now read-only.

8254881: Commit commandbuffer after draw happens through JNI #118

Closed

Conversation

@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Oct 16, 2020

Need to commit commanbuffer whenever we are drawing directly through JNI. Otherwise we will lose the content drawn on update.


Progress

  • Change must not contain extraneous whitespace

Testing

Linux x64 Windows x64 macOS x64
Build (3/3 running) (2/2 running) (2/2 running)

Issue

  • JDK-8254881: Commit commandbuffer after draw happens through JNI

Download

$ git fetch https://git.openjdk.java.net/lanai pull/118/head:pull/118
$ git checkout pull/118

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 16, 2020

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 16, 2020

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254881: Commit commandbuffer after draw happens through JNI

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@jayathirthrao
Copy link
Member Author

@jayathirthrao jayathirthrao commented Oct 16, 2020

/integrate

@openjdk openjdk bot closed this Oct 16, 2020
@openjdk openjdk bot added integrated and removed ready labels Oct 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 16, 2020

@jayathirthrao Pushed as commit 38e78cd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Oct 16, 2020
@jayathirthrao jayathirthrao deleted the JDK-8254881-flush-jni branch Oct 16, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 16, 2020

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant