Skip to content
This repository has been archived by the owner. It is now read-only.

8244718: J2DDemo - AlphaComposite tab - output colors are different with AA & non-AA #120

Closed
wants to merge 2 commits into from

Conversation

dekonoplyov
Copy link
Collaborator

@dekonoplyov dekonoplyov commented Oct 20, 2020

A straight forward approach to handle blending modes.

Fixes those bugs


Progress

  • Change must not contain extraneous whitespace

Testing

Linux x64 Windows x64 macOS x64
Build (2/5 running) (2/2 running) (1/2 failed)

Failed test task

Issue

  • JDK-8244718: J2DDemo - AlphaComposite tab - output colors are different with AA & non-AA

Download

$ git fetch https://git.openjdk.java.net/lanai pull/120/head:pull/120
$ git checkout pull/120

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 20, 2020

👋 Welcome back dekonoplyov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2020

⚠️ @dekonoplyov the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8244718
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2020

@dekonoplyov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8244718: J2DDemo - AlphaComposite tab - output colors are different with AA & non-AA

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Oct 20, 2020
@dekonoplyov
Copy link
Collaborator Author

@dekonoplyov dekonoplyov commented Oct 20, 2020

/integrate

@openjdk openjdk bot added the sponsor label Oct 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2020

@dekonoplyov
Your change (at version 4e6801e) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 20, 2020

Webrevs

@openjdk openjdk bot removed the sponsor label Oct 20, 2020
@avu
Copy link
Collaborator

@avu avu commented Oct 20, 2020

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2020

@avu The PR has been updated since the change author (@dekonoplyov) issued the integrate command - the author must perform this command again.

@dekonoplyov
Copy link
Collaborator Author

@dekonoplyov dekonoplyov commented Oct 20, 2020

/integrate

@openjdk openjdk bot added the sponsor label Oct 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2020

@dekonoplyov
Your change (at version 2a50325) is now ready to be sponsored by a Committer.

@avu
Copy link
Collaborator

@avu avu commented Oct 20, 2020

/sponsor

@openjdk openjdk bot closed this Oct 20, 2020
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Oct 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2020

@avu @dekonoplyov Pushed as commit e47e233.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated
2 participants