Skip to content
This repository has been archived by the owner. It is now read-only.

8248129: Swingmark numbers are not good for Nimbus LAF #124

Closed
wants to merge 5 commits into from

Conversation

jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Nov 5, 2020

Under this change we are removing MultiSample approach for Anti Aliasing and use shaders for the same.
With this change we are seeing improvement in Swingmark numbers for Nimbus LAF and now it is matching or ecxeeding OpenGL numbers and also there is significant improvement in RenderPerfTest numbers where we are drawing Parallelogram with AA.

This change also fixes https://bugs.openjdk.java.net/browse/JDK-8255212 as it is related AA state management.

Code related to MultiSampling in MTLTexturePool and MTLUtils is not removed because we might use that in future.
More analysis is captured in the bug.


Progress

  • Change must not contain extraneous whitespace

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issues

  • JDK-8248129: Swingmark numbers are not good for Nimbus LAF
  • JDK-8255212: J2DDemo : Rectangle in Texture paint disappears if we enable AA

Download

$ git fetch https://git.openjdk.java.net/lanai pull/124/head:pull/124
$ git checkout pull/124

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 5, 2020

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2020

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8248129: Swingmark numbers are not good for Nimbus LAF
8255212: J2DDemo : Rectangle in Texture paint disappears if we enable AA

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Nov 5, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 5, 2020

Webrevs

@jayathirthrao
Copy link
Member Author

@jayathirthrao jayathirthrao commented Nov 5, 2020

/issue 8255212

@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2020

@jayathirthrao
Adding additional issue to issue list: 8255212: J2DDemo : Rectangle in Texture paint disappears if we enable AA.

@jayathirthrao
Copy link
Member Author

@jayathirthrao jayathirthrao commented Nov 5, 2020

/integrate

@openjdk openjdk bot closed this Nov 5, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2020

@jayathirthrao Pushed as commit ced2058.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jayathirthrao jayathirthrao deleted the JDK-8248129 branch Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated
1 participant