Skip to content
This repository has been archived by the owner. It is now read-only.

8252954: Lanai : java/awt/datatransfer/DataFlavor/DataFlavorRemoteTest.java fails #128

Closed
wants to merge 1 commit into from

Conversation

jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Nov 17, 2020

We are printing additional logs in stderr and it is causing some tests to fail.
Made similar change as it is done for other fprintf cases by adding debug macro.


Progress

  • Change must not contain extraneous whitespace

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build (6/6 running) (2/2 running) (2/2 running) (2/2 running)

Issues

  • JDK-8252954: Lanai : java/awt/datatransfer/DataFlavor/DataFlavorRemoteTest.java fails
  • JDK-8252951: Lanai : java/awt/Robot/NonEmptyErrorStream.java fails

Download

$ git fetch https://git.openjdk.java.net/lanai pull/128/head:pull/128
$ git checkout pull/128

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 17, 2020

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2020

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252954: Lanai : java/awt/datatransfer/DataFlavor/DataFlavorRemoteTest.java fails
8252951: Lanai : java/awt/Robot/NonEmptyErrorStream.java fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Nov 17, 2020
@jayathirthrao
Copy link
Member Author

@jayathirthrao jayathirthrao commented Nov 17, 2020

/issue 8252951

@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2020

@jayathirthrao
Adding additional issue to issue list: 8252951: Lanai : java/awt/Robot/NonEmptyErrorStream.java fails.

@jayathirthrao
Copy link
Member Author

@jayathirthrao jayathirthrao commented Nov 17, 2020

/integrate

@openjdk openjdk bot closed this Nov 17, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2020

@jayathirthrao Pushed as commit 501ace0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jayathirthrao jayathirthrao deleted the JDK-8252954 branch Nov 17, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 17, 2020

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated
1 participant