Skip to content
This repository has been archived by the owner. It is now read-only.

JDK-8241422: Regression in RenderPerfTest after JDK-8238535 #13

Closed
wants to merge 1 commit into from

Conversation

avu
Copy link
Collaborator

@avu avu commented Mar 24, 2020

Corrected state management logic


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8241422: Regression in RenderPerfTest after JDK-8238535

Download

$ git fetch https://git.openjdk.java.net/lanai pull/13/head:pull/13
$ git checkout pull/13

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 24, 2020

👋 Welcome back avu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk
Copy link

openjdk bot commented Mar 24, 2020

@avu This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

JDK-8241422: Regression in RenderPerfTest after JDK-8238535
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 45fea40dbdd6cc2c5969b5dc36900e5aef684c37.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 24, 2020
@avu
Copy link
Collaborator Author

avu commented Mar 24, 2020

/integrate

@avu avu closed this Mar 24, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 24, 2020
@openjdk
Copy link

openjdk bot commented Mar 24, 2020

@avu
Pushed as commit 45fea40.

@mlbridge
Copy link

mlbridge bot commented Mar 26, 2020

Webrevs

@kevinrushforth
Copy link
Member

kevinrushforth commented Mar 26, 2020

Since we don't have jcheck configured to require a vaild issue ID, this worked, but for future reference, the JDK- prefix should not be included before the bug ID in question. So the title should have been:

8241422: Regression in RenderPerfTest after JDK-8238535

@avu avu deleted the JDK-8241422 branch Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated Pull request has been integrated
2 participants