-
Notifications
You must be signed in to change notification settings - Fork 14
8247332: Checkbox reaches inconsistent state on tap to click #146
Conversation
👋 Welcome back jdv! A progress list of the required criteria for merging this PR into |
@jayathirthrao This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 57 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/issue add 8251477,8247739,8252501,8242187,8252907 |
@jayathirthrao Adding additional issue to issue list: Adding additional issue to issue list: Adding additional issue to issue list: Adding additional issue to issue list: |
/integrate |
@jayathirthrao Since your change was applied there have been 57 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 5263974. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Mailing list message from Alexey Ushakov on lanai-dev: Hi Jay, I?ve just updated my sources to the latest Lanai version and found one problem - continuous execution of the following methods for the simple static UI application: [V] MTLLayer_display() called It?s look like waste of CPU time. Did you measured CPU usage before/after the fix? Best Regards, |
Mailing list message from Alan Snyder on lanai-dev: Do your UI by any chance have a blinking caret?
|
Mailing list message from Alexey Ushakov on lanai-dev: No, It?s just static picture. CVDisplayLink is the reason of the continuous callbacks. It?s a good thing if you do animation, but for async updated model it is not necessary. Probably we should suspend display link (there is an api for this) after receiving all necessary updates.
|
Mailing list message from Ajit Ghaisas on lanai-dev: Hi Alexey, Jay and I have discussed this internally yesterday. Regards,
|
Mailing list message from Alexey Ushakov on lanai-dev: Thanks, Ajit! Nevertheless I think that we still can use CVDisplayLink for our purpose (it should help for such things as live resize/animation) but we need to suspend it in the idle state of application. Best Regards,
|
Mailing list message from Kevin Rushforth on lanai-dev: FWIW, we ran into the same thing for JavaFX. We also added logic to -- Kevin On 12/23/2020 1:44 AM, Alexey Ushakov wrote:
|
Mailing list message from Jayathirth D v on lanai-dev: Hi Alexey, Thanks for noticing this, we had discussion regarding the same before year end break. I have created https://bugs.openjdk.java.net/browse/JDK-8259038 <https://bugs.openjdk.java.net/browse/JDK-8259038> to handle this issue. Thanks,
|
This fix implements usage of CVDisplayLink for blitting content into CAMetalLayer and solves many event based state issues. Detailed analysis in JBS bug.
Progress
Issues
Download
$ git fetch https://git.openjdk.java.net/lanai pull/146/head:pull/146
$ git checkout pull/146