Skip to content
This repository has been archived by the owner. It is now read-only.

8260000: Remove JNF_COCOA_ENTER/EXIT usage from MTLGraphicsConfig.m #156

Closed
wants to merge 1 commit into from

Conversation

@aghaisas
Copy link
Collaborator

@aghaisas aghaisas commented Jan 19, 2021

Usage of JNF_COCOA_ENTER/EXIT was replaced in Lanai code-base under JDK-8259939, but fix of JDK-8258754 has introduced an instance in MTLGraphicsConfig.m. It needs to be replaced.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8260000: Remove JNF_COCOA_ENTER/EXIT usage from MTLGraphicsConfig.m

Download

$ git fetch https://git.openjdk.java.net/lanai pull/156/head:pull/156
$ git checkout pull/156

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 19, 2021

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 19, 2021

@aghaisas This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260000: Remove JNF_COCOA_ENTER/EXIT usage from MTLGraphicsConfig.m

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@aghaisas
Copy link
Collaborator Author

@aghaisas aghaisas commented Jan 19, 2021

/integrate

@openjdk openjdk bot closed this Jan 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 19, 2021

@aghaisas Pushed as commit 1aeed78.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 19, 2021

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant