Skip to content
This repository has been archived by the owner. It is now read-only.

8260554: Missing copyright headers on some Lanai files #160

Closed
wants to merge 3 commits into from
Closed

8260554: Missing copyright headers on some Lanai files #160

wants to merge 3 commits into from

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jan 27, 2021

  1. Add missing copyright headers
  2. Revert changes to files that only differ from jdk/master in copyright years or whitespace changes
  3. Update copyright years to 2021

Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8260554: Missing copyright headers on some Lanai files

Download

$ git fetch https://git.openjdk.java.net/lanai pull/160/head:pull/160
$ git checkout pull/160

Revert changes to files that only differ from jdk/master in copyright years or whitespace changes
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 27, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 27, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260554: Missing copyright headers on some Lanai files

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jan 27, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 27, 2021

Webrevs

@kevinrushforth
Copy link
Member Author

kevinrushforth commented Jan 27, 2021

I'll wait a while in case anyone wants to take a look at this before I integrate it. Each of the three items above was done in a separate commit (it was easier for me and might make it easier to review). Skara will, as always, squash it into a single commit.

@kevinrushforth
Copy link
Member Author

kevinrushforth commented Jan 27, 2021

/integrate

@openjdk openjdk bot closed this Jan 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 27, 2021
@openjdk
Copy link

openjdk bot commented Jan 27, 2021

@kevinrushforth Pushed as commit 10cabad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@@ -1,3 +1,28 @@
/*
* Copyright (c) 2019, 2021, Oracle and/or its affiliates. All rights reserved.
Copy link
Member

@jayathirthrao jayathirthrao Jan 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we include starting year for files which were added in JDK projects like Lanai when we send out common review for OpenJDK? Is this a common practice?

@kevinrushforth kevinrushforth deleted the 8260554-fix-copyright branch Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated
2 participants