Skip to content
This repository has been archived by the owner. It is now read-only.

8260640: Cleanup dead code and comments imported from OpenGL #164

Closed
wants to merge 1 commit into from

Conversation

jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Jan 29, 2021

Clean up of unused code and removal/updation of comments imported from OpenGL.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8260640: Cleanup dead code and comments imported from OpenGL

Download

$ git fetch https://git.openjdk.java.net/lanai pull/164/head:pull/164
$ git checkout pull/164

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 29, 2021

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 29, 2021

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260640: Cleanup dead code and comments imported from OpenGL

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jan 29, 2021
@jayathirthrao
Copy link
Member Author

jayathirthrao commented Jan 29, 2021

/integrate

@openjdk openjdk bot closed this Jan 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 29, 2021
@openjdk
Copy link

openjdk bot commented Jan 29, 2021

@jayathirthrao Pushed as commit a6f59f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jayathirthrao jayathirthrao deleted the cleanup branch Jan 29, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 29, 2021

Webrevs

@kevinrushforth
Copy link
Member

kevinrushforth commented Jan 29, 2021

Looks like this fix broke the build. I filed https://bugs.openjdk.java.net/browse/JDK-8260651

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated
2 participants