Skip to content
This repository has been archived by the owner. It is now read-only.

8260857: Remove JNFWeakJObjectWrapper from Lanai Project #171

Closed
wants to merge 1 commit into from
Closed

8260857: Remove JNFWeakJObjectWrapper from Lanai Project #171

wants to merge 1 commit into from

Conversation

@prrace
Copy link
Collaborator

@prrace prrace commented Feb 1, 2021

Needed to prevent future build breakage


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8260857: Remove JNFWeakJObjectWrapper from Lanai Project

Download

$ git fetch https://git.openjdk.java.net/lanai pull/171/head:pull/171
$ git checkout pull/171

@prrace
Copy link
Collaborator Author

@prrace prrace commented Feb 1, 2021

/integrate

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 1, 2021

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2021

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260857: Remove JNFWeakJObjectWrapper from Lanai Project

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2021

⚠️ @prrace a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 5aca2ac657dbd0e831326b384daa0bf5c98c237d
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk openjdk bot closed this Feb 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2021

@prrace Pushed as commit 7bf226f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 1, 2021

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant