Skip to content
This repository has been archived by the owner. It is now read-only.

8261620: Running metal with API validation crashes immediately #184

Closed

Conversation

@aghaisas
Copy link
Collaborator

@aghaisas aghaisas commented Feb 12, 2021

Root cause : Trying to copy backbuffer-texture to frontbuffer-texture after accommodating for Insets causes some overflow which is detected only with Metal API validation.

Fix : Adjusted texture size to be copied to accommodate insets.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8261620: Running metal with API validation crashes immediately

Download

$ git fetch https://git.openjdk.java.net/lanai pull/184/head:pull/184
$ git checkout pull/184

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 12, 2021

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 12, 2021

@aghaisas This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261620: Running metal with API validation crashes immediately

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 12, 2021

Webrevs

@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Feb 12, 2021

This patch resolves API validation error captured at : openjdk/jdk#2403 (comment)
I have verified running J2DDemo, SwingSet2 and Font2DTest.

@aghaisas
Copy link
Collaborator Author

@aghaisas aghaisas commented Feb 12, 2021

/integrate

@openjdk openjdk bot closed this Feb 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 12, 2021

@aghaisas Pushed as commit 234186f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants