8261632: Cached text AA rendering crashes with Metal API validation

[jayathirthrao]

setVertexBytes can take maximum of 4KB data and in cases where we are exceeding this size for vertexCache in cached AA text rendering Metal API validation throws an error. We need to clamp our vertexCache size to 4KB. It resolves the issue, Sanity and Performance tests are green.

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8261632: Cached text AA rendering crashes with Metal API validation

Download

$ git fetch https://git.openjdk.java.net/lanai pull/185/head:pull/185
$ git checkout pull/185

[bridgekeeper]

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261632: Cached text AA rendering crashes with Metal API validation

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (ff23387)

[jayathirthrao]

/integrate

[openjdk]

@jayathirthrao Pushed as commit 97ccc3b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[kevinrushforth]

It would be helpful to add a comment about why the max index is 250. Do you think it is worth filing a follow-up issue?

[jayathirthrao]

Hi Kevin,

J2DVertex size is 16 bytes and since setVertexBytes has a limit of 4KB we can have maximum of 250 J2DVertex elements. I have created https://bugs.openjdk.java.net/browse/JDK-8261650 to add the comment.

Thanks,
Jay