Skip to content
This repository has been archived by the owner. It is now read-only.

8242035: Combine drawPrimitive calls in text drawing flush #19

Closed
wants to merge 1 commit into from
Closed

8242035: Combine drawPrimitive calls in text drawing flush #19

wants to merge 1 commit into from

Conversation

@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Apr 2, 2020

We issue drawPrimitive call per quad in MTLVertexCache.
We can encode all quads present in vertexcache at once.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8242035: Combine drawPrimitive calls in text drawing flush

Contributors

  • Ajit Ghaisas <ajit.ghaisas@oracle.com>

Download

$ git fetch https://git.openjdk.java.net/lanai pull/19/head:pull/19
$ git checkout pull/19

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 2, 2020

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2020

@jayathirthrao This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242035: Combine drawPrimitive calls in text drawing flush

Co-authored-by: Ajit Ghaisas <ajit.ghaisas@oracle.com>
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@jayathirthrao
Copy link
Member Author

@jayathirthrao jayathirthrao commented Apr 2, 2020

/contributor aghaisas

@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2020

@jayathirthrao Syntax: /contributor (add|remove) Full Name <email@address>

@jayathirthrao
Copy link
Member Author

@jayathirthrao jayathirthrao commented Apr 2, 2020

/contributor add Ajit Ghaisas ajit.ghaisas@oracle.com

@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2020

@jayathirthrao
Contributor Ajit Ghaisas <ajit.ghaisas@oracle.com> successfully added.

@jayathirthrao
Copy link
Member Author

@jayathirthrao jayathirthrao commented Apr 2, 2020

/integrate

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 2, 2020

Webrevs

@openjdk openjdk bot closed this Apr 2, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2020

@jayathirthrao
Pushed as commit 9cb40a9.

@jayathirthrao jayathirthrao deleted the JDK-8242035-combine-drawPrimitive branch Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant