Skip to content
This repository has been archived by the owner. It is now read-only.

8261705: Swing jtreg tests fail Metal API Validation with missing buffer binding #191

Conversation

@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Feb 14, 2021

We are hitting MTLRenderer_DrawScanLine with scanlineCount=0. So we end up calling drawPrimitives without actual vertex data. This is causing error when Metal API Validation is enabled. In OpenGL we have null checks for scanline data as well as scanlinecount. We need similar check in case of Metal.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8261705: Swing jtreg tests fail Metal API Validation with missing buffer binding

Download

$ git fetch https://git.openjdk.java.net/lanai pull/191/head:pull/191
$ git checkout pull/191

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 14, 2021

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 14, 2021

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261705: Swing jtreg tests fail Metal API Validation with missing buffer binding

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@jayathirthrao
Copy link
Member Author

@jayathirthrao jayathirthrao commented Feb 14, 2021

/integrate

@openjdk openjdk bot closed this Feb 14, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 14, 2021

@jayathirthrao Pushed as commit 2a30ee5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jayathirthrao jayathirthrao deleted the jayathirthrao:JDK-8261705_vertex_buffer_binding branch Feb 14, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 14, 2021

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant