Skip to content
This repository has been archived by the owner. It is now read-only.

8261703: Many java/awt/ tests fail with Metal API Validation Stencil PixelFormat error #194

Conversation

jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Feb 17, 2021

In LCD text rendering we get texture encoder which takes same shader parameters as LCD and then update its pipeline state locally and not in centralized MTLPaints. In cases where we use stencil based rendering and then move to LCD we will have invalid stencil state(Eventhough it doesnt change LCD text rendering output) because we override pipeline state locally after getting encoder. Moving LCD encoder state management to EncoderManager will resolve the issue when Metal API Validation is enabled.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8261703: Many java/awt/ tests fail with Metal API Validation Stencil PixelFormat error

Download

$ git fetch https://git.openjdk.java.net/lanai pull/194/head:pull/194
$ git checkout pull/194

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 17, 2021

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 17, 2021

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261703: Many java/awt/ tests fail with Metal API Validation Stencil PixelFormat error

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Feb 17, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 17, 2021

Webrevs

@jayathirthrao
Copy link
Member Author

@jayathirthrao jayathirthrao commented Feb 17, 2021

/integrate

@openjdk openjdk bot closed this Feb 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 17, 2021

@jayathirthrao Pushed as commit 22b1c08.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jayathirthrao jayathirthrao deleted the JDK-8261703_LCD_stencil_error branch Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated
1 participant