Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233314: LCD Text rendering implementation with glyph cache #2

Closed
wants to merge 1 commit into from

Conversation

@prsadhuk
Copy link
Collaborator

prsadhuk commented Mar 4, 2020

Make LCD implementation with glyph cache algorithm same as without cache.
Enabled LCD text remdering. JCK manual instructions are now being shown but albeit with lighter contrast.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8233314: LCD text rendering implementation with glyph cache

Download

$ git fetch https://git.openjdk.java.net/lanai pull/2/head:pull/2
$ git checkout pull/2

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2020

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk
Copy link

openjdk bot commented Mar 4, 2020

@prsadhuk This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8233314: LCD Text rendering implementation with glyph cache
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Mar 4, 2020
@prsadhuk
Copy link
Collaborator Author

prsadhuk commented Mar 4, 2020

/integrate

@openjdk openjdk bot closed this Mar 4, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 4, 2020
@openjdk
Copy link

openjdk bot commented Mar 4, 2020

@prsadhuk
Pushed as commit f66a1f1.

@prsadhuk prsadhuk deleted the prsadhuk:lcdtext branch Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.