Skip to content
This repository has been archived by the owner. It is now read-only.

8262928: Commit commandbuffer and gracefully override MTLContext #208

Closed
wants to merge 1 commit into from

Conversation

jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Mar 3, 2021

This is a follow up code verification task after https://bugs.openjdk.java.net/browse/JDK-8262750.
If we are overriding an active MTLContext we need to commit the GPU queue to maintain proper state.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8262928: Commit commandbuffer and gracefully override MTLContext

Download

$ git fetch https://git.openjdk.java.net/lanai pull/208/head:pull/208
$ git checkout pull/208

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 3, 2021

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 3, 2021

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262928: Commit commandbuffer and gracefully override MTLContext

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

  • 4188413: Automatic merge of jdk:master into master
  • 044e2a2: 8183569: Assert the same limits are used in parse_xss and globals.hpp
  • 5de0f4b: 8260869: Test java/foreign/TestHandshake.java fails intermittently
  • c9097a6: 8262893: Enable more doclint checks in javadoc build
  • 40bdf52: 8262096: Vector API fails to work due to VectorShape initialization exception
  • 93ffe6a: 8262892: minor typo in implSpec comment
  • 4f4d0f5: 8261969: SNIHostName should check if the encoded hostname conform to RFC 3490
  • c92f3bc: 8262876: Shenandoah: Fix comments regarding VM_ShenandoahOperation inheritances
  • 20b9ba5: 8262875: doccheck: empty paragraphs, etc in java.base module
  • f304b74: 8261859: gc/g1/TestStringDeduplicationTableRehash.java failed with "RuntimeException: 'Rehash Count: 0' found in stdout"
  • ... and 31 more: https://git.openjdk.java.net/lanai/compare/5bb76c338f7b9d956565527c4ed00b553fbd4bca...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Mar 3, 2021
@jayathirthrao
Copy link
Member Author

@jayathirthrao jayathirthrao commented Mar 3, 2021

/integrate

@openjdk openjdk bot closed this Mar 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 3, 2021

@jayathirthrao Since your change was applied there have been 41 commits pushed to the master branch:

  • 4188413: Automatic merge of jdk:master into master
  • 044e2a2: 8183569: Assert the same limits are used in parse_xss and globals.hpp
  • 5de0f4b: 8260869: Test java/foreign/TestHandshake.java fails intermittently
  • c9097a6: 8262893: Enable more doclint checks in javadoc build
  • 40bdf52: 8262096: Vector API fails to work due to VectorShape initialization exception
  • 93ffe6a: 8262892: minor typo in implSpec comment
  • 4f4d0f5: 8261969: SNIHostName should check if the encoded hostname conform to RFC 3490
  • c92f3bc: 8262876: Shenandoah: Fix comments regarding VM_ShenandoahOperation inheritances
  • 20b9ba5: 8262875: doccheck: empty paragraphs, etc in java.base module
  • f304b74: 8261859: gc/g1/TestStringDeduplicationTableRehash.java failed with "RuntimeException: 'Rehash Count: 0' found in stdout"
  • ... and 31 more: https://git.openjdk.java.net/lanai/compare/5bb76c338f7b9d956565527c4ed00b553fbd4bca...master

Your commit was automatically rebased without conflicts.

Pushed as commit d3d1daa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jayathirthrao jayathirthrao deleted the JDK-8262928 branch Mar 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 3, 2021

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated
1 participant