Skip to content
This repository has been archived by the owner. It is now read-only.

8262936: Add tighter checks while creating MTLRenderPipelineDescriptors #209

Closed
wants to merge 1 commit into from

Conversation

@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Mar 3, 2021

Added tighter null checks and initialization of MTLRenderPipelineDescriptor templates for all paint types.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8262936: Add tighter checks while creating MTLRenderPipelineDescriptors

Download

$ git fetch https://git.openjdk.java.net/lanai pull/209/head:pull/209
$ git checkout pull/209

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 3, 2021

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 3, 2021

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262936: Add tighter checks while creating MTLRenderPipelineDescriptors

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@jayathirthrao
Copy link
Member Author

@jayathirthrao jayathirthrao commented Mar 3, 2021

/integrate

@openjdk openjdk bot closed this Mar 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 3, 2021

@jayathirthrao Pushed as commit 41df642.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jayathirthrao jayathirthrao deleted the JDK-8262936 branch Mar 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 3, 2021

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant