8242185: Lanai: JDK built on macOS 10.15 fails to run on macOS 10.13 #21
Conversation
|
@kevinrushforth This change now passes all automated pre-integration checks, type
|
/summary Specify metal version 2.0 when compiling shaders |
@kevinrushforth Setting summary to |
/integrate |
@kevinrushforth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
By default, the
metal
shader compiler generates code for the highest metal shader language version supported by the SDK being used and the system on which it is compiled. So when building on macOS 10.15 (and maybe 10.14 but I didn't try it), it will use metal shader version 2.1. The highest version supported on macOS 10.13 is shader version 2.0.The simple fix is to specify the shader version when compiling the metal shader.
Progress
Issue
Download
$ git fetch https://git.openjdk.java.net/lanai pull/21/head:pull/21
$ git checkout pull/21