Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242185: Lanai: JDK built on macOS 10.15 fails to run on macOS 10.13 #21

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 7, 2020

By default, the metal shader compiler generates code for the highest metal shader language version supported by the SDK being used and the system on which it is compiled. So when building on macOS 10.15 (and maybe 10.14 but I didn't try it), it will use metal shader version 2.1. The highest version supported on macOS 10.13 is shader version 2.0.

The simple fix is to specify the shader version when compiling the metal shader.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8242185: Lanai: JDK built on macOS 10.15 fails to run on macOS 10.13

Download

$ git fetch https://git.openjdk.java.net/lanai pull/21/head:pull/21
$ git checkout pull/21

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 7, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2020

@kevinrushforth This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242185: Lanai: JDK built on macOS 10.15 fails to run on macOS 10.13

Specify metal version 2.0 when compiling shaders
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Apr 7, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Apr 7, 2020

/summary Specify metal version 2.0 when compiling shaders

@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2020

@kevinrushforth Setting summary to Specify metal version 2.0 when compiling shaders

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Apr 7, 2020

/integrate

@openjdk openjdk bot closed this Apr 7, 2020
@openjdk openjdk bot added the integrated label Apr 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2020

@kevinrushforth
Pushed as commit 5574cca.

@openjdk openjdk bot removed ready rfr labels Apr 7, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 7, 2020

Webrevs

@kevinrushforth kevinrushforth deleted the kevinrushforth:8242185-metal-compile branch Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant