Skip to content
This repository has been archived by the owner. It is now read-only.

8262882: Lanai: NetBeans crashes often when switching between dual and single screen #211

Closed
wants to merge 1 commit into from

Conversation

@aghaisas
Copy link
Collaborator

@aghaisas aghaisas commented Mar 9, 2021

Corrected MTLContext.dealloc() method to set released members to nil.
Setting texturePool member to nil causes double release as texturePool content gets released in MTLCommandBufferWrapper.onComplete() method as well.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8262882: Lanai: NetBeans crashes often when switching between dual and single screen

Download

$ git fetch https://git.openjdk.java.net/lanai pull/211/head:pull/211
$ git checkout pull/211

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 9, 2021

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 9, 2021

@aghaisas This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262882: Lanai: NetBeans crashes often when switching between dual and single screen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 9, 2021

Webrevs

@aghaisas
Copy link
Collaborator Author

@aghaisas aghaisas commented Mar 9, 2021

/integrate

@openjdk openjdk bot closed this Mar 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 9, 2021

@aghaisas Pushed as commit be067d4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant