Skip to content
This repository has been archived by the owner on Aug 27, 2022. It is now read-only.

8242444: LCD Text Rendering characters other than 1st are not rendere… #22

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Collaborator

@prsadhuk prsadhuk commented Apr 9, 2020

It is found that invgamma sent to shader for LCD Text rendering was wrong from 2nd character onwards causing subsequent characters to be not rendered properly. Rectified invgamma value to be sent to shader.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8242444: LCD Text Rendering characters other than 1st are not rendered properly

Download

$ git fetch https://git.openjdk.java.net/lanai pull/22/head:pull/22
$ git checkout pull/22

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 9, 2020

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk
Copy link

openjdk bot commented Apr 9, 2020

@prsadhuk This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242444: LCD Text Rendering characters other than 1st are not rendere…
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 9, 2020
@prsadhuk
Copy link
Collaborator Author

prsadhuk commented Apr 9, 2020

/integrate

@openjdk openjdk bot closed this Apr 9, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 9, 2020
@openjdk
Copy link

openjdk bot commented Apr 9, 2020

@prsadhuk
Pushed as commit aeb0b44.

@mlbridge
Copy link

mlbridge bot commented Apr 9, 2020

Webrevs

@prsadhuk prsadhuk deleted the LCDText branch June 17, 2020 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated Pull request has been integrated
1 participant