Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233309: implement image rendering options #25

Closed
wants to merge 0 commits into from

Conversation

@artemm-bochkarev
Copy link

artemm-bochkarev commented Apr 9, 2020

bicubic is still unimplemented (metal doesn't support it from the box)


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8233309: Implement - Image Rendering Option - Interpolation

Download

$ git fetch https://git.openjdk.java.net/lanai pull/25/head:pull/25
$ git checkout pull/25

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 9, 2020

👋 Welcome back abochkarev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk
Copy link

openjdk bot commented Apr 9, 2020

@artemm-bochkarev This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8233309: implement image rendering options
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Apr 9, 2020

⚠️ @artemm-bochkarev a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 8d90ece185a4caf6de76ad10b31c7023d08697fe
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk openjdk bot added ready rfr labels Apr 9, 2020
@artemm-bochkarev artemm-bochkarev force-pushed the artemm-bochkarev:master branch from b3884a5 to 8d90ece Apr 9, 2020
@mlbridge
Copy link

mlbridge bot commented Apr 9, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.