Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8243508: Update alpha blending and compositing functions #40

Closed
wants to merge 1 commit into from

Conversation

@avu
Copy link
Collaborator

@avu avu commented Apr 27, 2020

Corrected FLT_LT and FLT_GE macro
Fixed test/jdk/java/awt/image/DrawImage/IncorrectUnmanagedImageRotatedClip.java failure caused by fix of 8243505


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8243508: Update alpha blending and compositing functions

Download

$ git fetch https://git.openjdk.java.net/lanai pull/40/head:pull/40
$ git checkout pull/40

Corrected FLT_LT and FLT_GE macro
Fixed test/jdk/java/awt/image/DrawImage/IncorrectUnmanagedImageRotatedClip.java failure caused by fix of 8243505
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 27, 2020

👋 Welcome back avu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 27, 2020

@avu This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8243508: Update alpha blending and compositing functions
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 923bd0bb870bc0ebc4bdc358a02447d155d9d804.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Apr 27, 2020
@avu
Copy link
Collaborator Author

@avu avu commented Apr 27, 2020

/integrate

@openjdk openjdk bot closed this Apr 27, 2020
@openjdk openjdk bot added integrated and removed ready labels Apr 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 27, 2020

@avu
Pushed as commit 7c59839.

@openjdk openjdk bot removed the rfr label Apr 27, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 27, 2020

Webrevs

if (_compositeRule == java_awt_AlphaComposite_SRC ||
_compositeRule == java_awt_AlphaComposite_SRC_OVER)
{
return FLT_GE(_extraAlpha, 1.0f) && isSrcOpaque;
}
return isSrcOpaque;

This comment has been minimized.

@kevinrushforth

kevinrushforth Apr 27, 2020
Member

Thanks for fixing this. Btw, I think this still needs to be looked at. Unless there is a case I haven't thought of, both of extraAlphaIsOne and isSrcOpaque should be used, or else neither of them should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.