Skip to content
This repository has been archived by the owner. It is now read-only.

8243009: SwingSet2 scrolling doesn't repaint properly on Catalina #45

Closed
wants to merge 1 commit into from

Conversation

@aghaisas
Copy link
Collaborator

@aghaisas aghaisas commented May 14, 2020

Issue : https://bugs.openjdk.java.net/browse/JDK-8243009

Root cause : If the same texture is provided as source and destination with some offset, copyArea function results in texture tearing effect.

Fix : Copy the data from the source texture to a temporary buffer and then copy from that temporary buffer to the destination (source texture with some offset)

Note : This solution may be slower, need to find an optimum way to copy data from MTLTexture to the same texture with some offset.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8243009: SwingSet2 scrolling doesn't repaint properly on Catalina

Download

$ git fetch https://git.openjdk.java.net/lanai pull/45/head:pull/45
$ git checkout pull/45

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 14, 2020

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 14, 2020

@aghaisas This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8243009: SwingSet2 scrolling doesn't repaint properly on Catalina
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 5 commits pushed to the master branch:

  • 1773b20: 8243009: SwingSet2 scrolling doesn't repaint properly on Catalina
  • bd03d4d: Automatic merge of client:master into master
  • 4cf3e6b: 8238085: PIT: javax/swing/JSpinner/8223788/JSpinnerButtonFocusTest.java fails on Mac
  • 88a1f69: Automatic merge of client:master into master
  • 79905b1: 8229856: [macos] Opening a menu on a JTextField can clear the text selection

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 1773b20de20d1ccc009e48ac988c60cfd5486c3c.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@aghaisas
Copy link
Collaborator Author

@aghaisas aghaisas commented May 14, 2020

/integrate

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 14, 2020

Webrevs

@openjdk openjdk bot closed this May 14, 2020
@openjdk openjdk bot added integrated and removed ready labels May 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 14, 2020

@aghaisas The following commits have been pushed to master since your change was applied:

  • bd03d4d: Automatic merge of client:master into master
  • 4cf3e6b: 8238085: PIT: javax/swing/JSpinner/8223788/JSpinnerButtonFocusTest.java fails on Mac
  • 88a1f69: Automatic merge of client:master into master
  • 79905b1: 8229856: [macos] Opening a menu on a JTextField can clear the text selection

Your commit was automatically rebased without conflicts.

Pushed as commit 1773b20.

@openjdk openjdk bot removed the rfr label May 14, 2020
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented May 14, 2020

Nice work finding and fixing this! I'll test it shortly.

@aghaisas aghaisas deleted the copyAreaFix branch Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants