Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8240796: Infinite loop in Diagnostic message code #5

Closed
wants to merge 1 commit into from

Conversation

@prsadhuk
Copy link
Collaborator

@prsadhuk prsadhuk commented Mar 10, 2020

Issue:
Diagnostic message code causes an infinite loop

Fix:
Needs to put getc() inside while loop


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8240796: Infinite loop in Diagnostic message code

Download

$ git fetch https://git.openjdk.java.net/lanai pull/5/head:pull/5
$ git checkout pull/5

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 10, 2020

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@prsadhuk
Copy link
Collaborator Author

@prsadhuk prsadhuk commented Mar 10, 2020

get() code needs to be checked inside loop.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 10, 2020

@prsadhuk This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8240796: Infinite loop in Diagnostic message code
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 8b636c6a874a5a1540de918a952bc6fc01b04ca8.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Mar 10, 2020
@prsadhuk
Copy link
Collaborator Author

@prsadhuk prsadhuk commented Mar 10, 2020

/integrate

@openjdk openjdk bot closed this Mar 10, 2020
@openjdk openjdk bot added integrated and removed ready labels Mar 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 10, 2020

@prsadhuk
Pushed as commit 8b636c6.

@openjdk openjdk bot removed the rfr label Mar 10, 2020
@prsadhuk prsadhuk deleted the prsadhuk:MetalSupport2 branch Apr 7, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 7, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant