Skip to content
This repository has been archived by the owner. It is now read-only.

8242354: support for bufImgOps (RescaleOp, LookupOp, ConvolveOp) #51

Closed
wants to merge 1 commit into from

Conversation

avu
Copy link
Collaborator

@avu avu commented Jun 2, 2020

Refactoring as bonus (use single struct instead of parameters lists)
Authored-by: Artem Bochkarev abochkarev@openjdk.org


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8242354: Implement MaskBlit ⚠️ Title mismatch between PR and JBS.

Contributors

  • Artem Bochkarev <abochkarev@openjdk.org>

Download

$ git fetch https://git.openjdk.java.net/lanai pull/51/head:pull/51
$ git checkout pull/51

Refactoring as bonus (use single struct instead of parameters lists)
Authored-by: Artem Bochkarev <abochkarev@openjdk.org>
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 2, 2020

👋 Welcome back avu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2020

@avu This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242354: support for bufImgOps (RescaleOp, LookupOp, ConvolveOp)

Co-authored-by: Artem Bochkarev <abochkarev@openjdk.org>
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • a403550: 8242354: support for bufImgOps (RescaleOp, LookupOp, ConvolveOp)

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate a403550cebfb69e8cc8a947e2c71bdc55d6846e1.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jun 2, 2020
@avu
Copy link
Collaborator Author

@avu avu commented Jun 2, 2020

/contributor abochkarev

@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2020

@avu Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

@avu
Copy link
Collaborator Author

@avu avu commented Jun 2, 2020

/contributor add Artem Bochkarev abochkarev@openjdk.org

@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2020

@avu
Contributor Artem Bochkarev <abochkarev@openjdk.org> successfully added.

@avu
Copy link
Collaborator Author

@avu avu commented Jun 2, 2020

/integrate

@openjdk openjdk bot closed this Jun 2, 2020
@openjdk openjdk bot added integrated and removed ready labels Jun 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2020

@avu
Pushed as commit a403550.

@openjdk openjdk bot removed the rfr label Jun 2, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 2, 2020

Webrevs

@avu avu deleted the JDK-8242354 branch Jun 2, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 3, 2020

Mailing list message from Ajit Ghaisas on lanai-dev:

Thanks for implementing this.
The PR contains incorrect bug number : 8242354 which was used for MaskBlit.
Correct JBS is - JDK-8242355 <https://bugs.openjdk.java.net/browse/JDK-8242355>

Regards,
Ajit

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 3, 2020

Mailing list message from Alexey Ushakov on lanai-dev:

Hi Ajit,

Thanks for the correction. I?ve just published some of Artem?s work (while he is on a leave) from our internal repo to avoid merge conflicts in the future.

Best Regards,
Alexey

On 3 Jun 2020, at 14:52, Ajit Ghaisas <ajit.ghaisas at oracle.com> wrote:

Thanks for implementing this.
The PR contains incorrect bug number : 8242354 which was used for MaskBlit.
Correct JBS is - JDK-8242355 <https://bugs.openjdk.java.net/browse/JDK-8242355>

Regards,
Ajit

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated
2 participants