Skip to content
This repository has been archived by the owner. It is now read-only.

8247831: Clamp texture height to maxTextureSize(16384) #63

Closed
wants to merge 1 commit into from

Conversation

@prsadhuk
Copy link
Collaborator

@prsadhuk prsadhuk commented Jul 17, 2020

In accordance with OpenGL clamping code done in OGLSurfaceData.c#OGLSD_InitTextureObject, the texture width/height is clamped w.r.t Max texture size.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8247831: Clamp texture height to maxTextureSize(16384)

Download

$ git fetch https://git.openjdk.java.net/lanai pull/63/head:pull/63
$ git checkout pull/63

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 17, 2020

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 17, 2020

@prsadhuk This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8247831: Clamp texture height to maxTextureSize(16384)
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 01159e733981adbb40086a0f0893400dfeb1f124.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@prsadhuk
Copy link
Collaborator Author

@prsadhuk prsadhuk commented Jul 17, 2020

/integrate

@openjdk openjdk bot closed this Jul 17, 2020
@openjdk openjdk bot added integrated and removed ready labels Jul 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 17, 2020

@prsadhuk
Pushed as commit a0d86b7.

@openjdk openjdk bot removed the rfr label Jul 17, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 17, 2020

Webrevs

@prsadhuk prsadhuk deleted the 8247831-clampheight branch Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant