Skip to content
This repository has been archived by the owner. It is now read-only.

8250778: [Lanai] Primitives rendered with metal on non-retina monitor are different as compared to OpenGL #70

Closed

Conversation

@aghaisas
Copy link
Collaborator

@aghaisas aghaisas commented Jul 30, 2020

Issue : https://bugs.openjdk.java.net/browse/JDK-8250778
Fix : Replicated pixel adjustments in Metal code similar to that of OpenGL code. Also, implemented DRAW_PIXEL operation.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8250778: [Lanai] Primitives rendered with metal on non-retina monitor are different as compared to OpenGL

Download

$ git fetch https://git.openjdk.java.net/lanai pull/70/head:pull/70
$ git checkout pull/70

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 30, 2020

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2020

@aghaisas This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8250778: [Lanai] Primitives rendered with metal on non-retina monitor are different as compared to OpenGL
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate a5c3460875b6e1d72e38e7616212f6e8058b5874.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@aghaisas aghaisas changed the title 8250778: [Lanai] Primitive rendered with metal on non-retina monitor are different as compared to OpenGL 8250778: [Lanai] Primitives rendered with metal on non-retina monitor are different as compared to OpenGL Jul 30, 2020
@aghaisas
Copy link
Collaborator Author

@aghaisas aghaisas commented Jul 30, 2020

/integrate

Loading

@openjdk openjdk bot closed this Jul 30, 2020
@openjdk openjdk bot added integrated and removed ready labels Jul 30, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2020

@aghaisas
Pushed as commit a057120.

Loading

@openjdk openjdk bot removed the rfr label Jul 30, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 30, 2020

Webrevs

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 30, 2020

Mailing list message from Ajit Ghaisas on lanai-dev:

Hi Alexey,

This changeset also fixes below 3 issues. Request you to verify and close them as duplicate.

JDK-8244402 : Lanai - Motif L&F - Non selected Radio button is barely rendered on non-retina display
JDK-8248831 : Lanai : SwingSet2Demo Input dialog is not proper for MetalLookAndFeel with default non-retina display
JDK-8247564 : Lanai - SwingSet2 - Motif L&F - UI controls border is incorrectly drawn with uiScale=1.0

Regards,
Ajit

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 30, 2020

Mailing list message from Alexey Ushakov on lanai-dev:

Hi Ajit,

Looks like you did the same thing that Denis has submitted via pull requests. https://github.com/openjdk/lanai/pulls <https://github.com/openjdk/lanai/pulls>
But for some reason he is unable to get through the process.

Best Regards,
Alexey

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 30, 2020

Mailing list message from Ajit Ghaisas on lanai-dev:

Hi Alexey,

Oh.. I did not check these PRs before pushing my fix :(

I was working on XOR mode and it was failing for uiScale=1.0. Hence, I root caused it and filed a new bug to fix it.

Regards,
Ajit

On 30-Jul-2020, at 12:57 PM, Alexey Ushakov <alexey.ushakov at jetbrains.com> wrote:

Hi Ajit,

Looks like you did the same thing that Denis has submitted via pull requests. https://github.com/openjdk/lanai/pulls <https://github.com/openjdk/lanai/pulls>
But for some reason he is unable to get through the process.

Best Regards,
Alexey

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 30, 2020

Mailing list message from Kevin Rushforth on lanai-dev:

It usually only takes a day or two. Since it's been ~ 3 days, I'll send
a query about the OCA verification.

-- Kevin

On 7/30/2020 12:27 AM, Alexey Ushakov wrote:

Hi Ajit,

Looks like you did the same thing that Denis has submitted via pull requests. https://github.com/openjdk/lanai/pulls <https://github.com/openjdk/lanai/pulls>
But for some reason he is unable to get through the process.

Best Regards,
Alexey

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 30, 2020

Mailing list message from Ajit Ghaisas on lanai-dev:

Hi,

As Denis had created his PRs 2 days ago (but stuck in the process), I will back out my changes and let him integrate his PRs.

Regards,
Ajit

On 30-Jul-2020, at 1:02 PM, Ajit Ghaisas <ajit.ghaisas at oracle.com> wrote:

Hi Alexey,

Oh.. I did not check these PRs before pushing my fix :(

I was working on XOR mode and it was failing for uiScale=1.0. Hence, I root caused it and filed a new bug to fix it.

Regards,
Ajit

On 30-Jul-2020, at 12:57 PM, Alexey Ushakov <alexey.ushakov at jetbrains.com> wrote:

Hi Ajit,

Looks like you did the same thing that Denis has submitted via pull requests. https://github.com/openjdk/lanai/pulls <https://github.com/openjdk/lanai/pulls>
But for some reason he is unable to get through the process.

Best Regards,
Alexey

Loading

@aghaisas aghaisas deleted the fix_non_retina_primitive_drawing branch Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant