Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233226: Implement XOR Mode rendering option #72

Closed
wants to merge 1 commit into from

Conversation

@aghaisas
Copy link
Collaborator

@aghaisas aghaisas commented Aug 3, 2020

Issue : https://bugs.openjdk.java.net/browse/JDK-8233226


Progress

  • Change must not contain extraneous whitespace

Issue

Download

$ git fetch https://git.openjdk.java.net/lanai pull/72/head:pull/72
$ git checkout pull/72

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 3, 2020

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 3, 2020

@aghaisas This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8233226: Implement XOR Mode rendering option
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 5 commits pushed to the master branch:

  • bd42485: Automatic merge of client:master into master
  • 889b463: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8 on Japanese Windows
  • 5880ed7: Automatic merge of client:master into master
  • 6943879: Merge
  • eaade7b: 8249566: jshell tool: retained modes from JDK-13 or prior cause confusing messages to be generated for records

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate bd424852bdf715aab6086479e5d02c1b26c2cc1a.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Aug 3, 2020
@aghaisas
Copy link
Collaborator Author

@aghaisas aghaisas commented Aug 3, 2020

/integrate

@openjdk openjdk bot closed this Aug 3, 2020
@openjdk openjdk bot added integrated and removed ready labels Aug 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 3, 2020

@aghaisas The following commits have been pushed to master since your change was applied:

  • bd42485: Automatic merge of client:master into master
  • 889b463: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8 on Japanese Windows
  • 5880ed7: Automatic merge of client:master into master
  • 6943879: Merge
  • eaade7b: 8249566: jshell tool: retained modes from JDK-13 or prior cause confusing messages to be generated for records

Your commit was automatically rebased without conflicts.

Pushed as commit 9cf06e4.

@openjdk openjdk bot removed the rfr label Aug 3, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 3, 2020

Webrevs

@aghaisas aghaisas deleted the aghaisas:xorMode_primitive_and_text branch Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.