Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8249659: [Lanai] Crash while running RenderPerfTest with metal pipeli… #75

Closed
wants to merge 1 commit into from

Conversation

@avu
Copy link
Collaborator

@avu avu commented Aug 6, 2020

…ne - wiredQuadAA

Removed release of autorelease object (MTLRenderPassDescriptor)


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8249659: [Lanai] Crash while running RenderPerfTest with metal pipeline - wiredQuadAA ⚠️ Title mismatch between PR and JBS.

Download

$ git fetch https://git.openjdk.java.net/lanai pull/75/head:pull/75
$ git checkout pull/75

…ne - wiredQuadAA

Removed release of autorelease object (MTLRenderPassDescriptor)
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 6, 2020

👋 Welcome back avu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 6, 2020

@avu This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8249659: [Lanai] Crash while running RenderPerfTest with metal pipeli…
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 69ed4f9804a198b6a7325603dd2fca740309d9cb.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Aug 6, 2020
@avu
Copy link
Collaborator Author

@avu avu commented Aug 6, 2020

/integrate

@openjdk openjdk bot closed this Aug 6, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 6, 2020

@avu
Pushed as commit 454407b.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 6, 2020

Webrevs

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 12, 2020

Mailing list message from Jayathirth D v on lanai-dev:

Hi Alexey,

This change has caused performance regression in RenderPerfTest FlatBoxAA.
JBS bug raised for the same : https://bugs.openjdk.java.net/browse/JDK-8251484 <https://bugs.openjdk.java.net/browse/JDK-8251484>

Thanks,
Jay

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 14, 2020

Mailing list message from Alexey Ushakov on lanai-dev:

Hi Jay,

Unfortunately we should not release MTLRenderPassDescriptor manually as it registered in some autorelease pool. So, when that pool is released we have a crash. But looks like the pool that is used for attaching MTLRenderPassDescriptor has not proper life time. I?m going to refactor memory management (rough idea is to have autorelease pool for each RenderQueue flush action).

BTW, this week I?m on vacation (be back on Tuesday next week)

Best Regards,
Alexey

On Aug 12, 2020, at 4:50 PM, Jayathirth D v <JAYATHIRTH.D.V at ORACLE.COM> wrote:

Hi Alexey,

This change has caused performance regression in RenderPerfTest FlatBoxAA.
JBS bug raised for the same : https://bugs.openjdk.java.net/browse/JDK-8251484 <https://bugs.openjdk.java.net/browse/JDK-8251484>

Thanks,
Jay

@avu avu deleted the avu:JDK-8249659 branch Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant